wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-08 16:58:38 +09:00
Code Issues Projects Releases Packages Wiki Activity

[network] Add some sanity checks to deserialized nsStandardURLs

Browse source 
Note: C++ lambda expressions are actually useful for once.
This commit is contained in:
Moonchild 2021-07-14 13:20:09 +00:00 • committed by roytam1
commit 43f7d3e27a
3 changed files with 108 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

51
netwerk/test/gtest/TestStandardURL.cpp
View file

@ -9,6 +9,10 @@
#include "nsComponentManagerUtils.h"
#include "nsIIPCSerializableURI.h"
#include "mozilla/ipc/URIUtils.h"
#include "mozilla/Unused.h"
#include "nsSerializationHelper.h"
#include "mozilla/Base64.h"
#include "nsEscape.h"
TEST(TestStandardURL, Simple) {
nsCOMPtr<nsIURL> url( do_CreateInstance(NS_STANDARDURL_CONTRACTID) );
@ -83,3 +87,50 @@ TEST(TestStandardURL, Deserialize_Bug1392739)
nsCOMPtr<nsIIPCSerializableURI> url = do_CreateInstance(NS_STANDARDURL_CID);
ASSERT_EQ(url->Deserialize(params), false);
}
TEST(TestStandardURL, CorruptSerialization)
{
auto spec = "http://user:pass@example.com/path/to/file.ext?query#hash"_ns;
nsCOMPtr<nsIURI> uri;
nsresult rv = NS_MutateURI(NS_STANDARDURLMUTATOR_CONTRACTID)
.SetSpec(spec)
.Finalize(uri);
ASSERT_EQ(rv, NS_OK);
nsAutoCString serialization;
nsCOMPtr<nsISerializable> serializable = do_QueryInterface(uri);
ASSERT_TRUE(serializable);
// Check that the URL is normally serializable.
ASSERT_EQ(NS_OK, NS_SerializeToString(serializable, serialization));
nsCOMPtr<nsISupports> deserializedObject;
ASSERT_EQ(NS_OK, NS_DeserializeObject(serialization,
getter_AddRefs(deserializedObject)));
nsAutoCString canonicalBin;
Unused << Base64Decode(serialization, canonicalBin);
// The spec serialization begins at byte 49
// If the implementation of nsStandardURL::Write changes, this test will need
// to be adjusted.
#define SPEC_OFFSET 49
ASSERT_EQ(Substring(canonicalBin, SPEC_OFFSET, 7), "http://"_ns);
nsAutoCString corruptedBin = canonicalBin;
// change mScheme.mPos
corruptedBin.BeginWriting()[SPEC_OFFSET + spec.Length()] = 1;
Unused << Base64Encode(corruptedBin, serialization);
ASSERT_EQ(
NS_ERROR_MALFORMED_URI,
NS_DeserializeObject(serialization, getter_AddRefs(deserializedObject)));
corruptedBin = canonicalBin;
// change mScheme.mLen
corruptedBin.BeginWriting()[SPEC_OFFSET + spec.Length() + 4] = 127;
Unused << Base64Encode(corruptedBin, serialization);
ASSERT_EQ(
NS_ERROR_MALFORMED_URI,
NS_DeserializeObject(serialization, getter_AddRefs(deserializedObject)));
}