wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-08-15 08:53:07 +09:00
Code Issues Projects Releases Packages Wiki Activity

Issue #3039 - Don't try to pass a dash array of > 16 elements to ExtCreatePen.

Browse source 
According to MSDN documentation, the count of the style array passed to
ExtCreatePen is limited to 16. When we call ExtCreatePen with cStyle=17 or more,
it simply returns an error and the cairo surface used for printing is getting
into an error state, after which nothing further gets printed.
Instead of erroring out, this code change returns an unsupported status so that
cairo will provide fallback handling for it.
This commit is contained in:
Moonchild 2021-11-20 23:05:25 +00:00 • committed by roytam1
commit 3bb1c962eb
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
gfx/cairo/cairo/src/cairo-win32-printing-surface.c
View file

@ -1265,6 +1265,9 @@ _cairo_win32_printing_surface_stroke (void *abstract_surface,
}
if (surface->paginated_mode == CAIRO_PAGINATED_MODE_ANALYZE) {
/* Win32 does not support more than 16 elements in the dash array. */
if (style->num_dashes > 16)
return CAIRO_INT_STATUS_UNSUPPORTED;
/* Win32 does not support a dash offset. */
if (style->num_dashes > 0 && style->dash_offset != 0.0)
return CAIRO_INT_STATUS_UNSUPPORTED;