wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-10-27 17:47:34 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1495698 - Fix hang when HTML signature references non-existent image.

Browse source 
Tag #1273
This commit is contained in:
Matt A. Tobin 2019-11-10 23:56:17 -05:00 • committed by Roy Tam
commit 3a92a80285
2 changed files with 47 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

19
mailnews/compose/src/nsMsgCompose.cpp
View file

@ -4350,14 +4350,20 @@ nsMsgCompose::LoadDataFromFile(nsIFile *file, nsString &sigData,
* images loaded into the editor are available on send. * images loaded into the editor are available on send.
*/ */
nsresult nsresult
nsMsgCompose::ReplaceFileURLs(nsAutoString &aData) nsMsgCompose::ReplaceFileURLs(nsString &aData)
{ {
int32_t fPos; int32_t fPos;
int32_t offset = -1; int32_t offset = -1; // We're using RFind(), so offset -1 is from the very right.
// XXX This code is rather incomplete since it looks for "file://" even
// outside tags.
while ((fPos = aData.RFind("file://", true, offset)) != kNotFound) { while ((fPos = aData.RFind("file://", true, offset)) != kNotFound) {
if (fPos != kNotFound && fPos > 0) { bool quoted = false;
char16_t q = aData.CharAt(fPos - 1); char16_t q = 'x'; // initialise to anything to keep compilers happy.
bool quoted = (q == '"' || q == '\''); if (fPos > 0) {
q = aData.CharAt(fPos - 1);
quoted = (q == '"' || q == '\'');
}
int32_t end = kNotFound; int32_t end = kNotFound;
if (quoted) { if (quoted) {
end = aData.FindChar(q, fPos); end = aData.FindChar(q, fPos);
@ -4387,9 +4393,10 @@ nsMsgCompose::ReplaceFileURLs(nsAutoString &aData)
if (NS_SUCCEEDED(rv)) { if (NS_SUCCEEDED(rv)) {
aData.Replace(fPos, end - fPos, dataURL); aData.Replace(fPos, end - fPos, dataURL);
} }
if (fPos == 0)
break;
offset = fPos - 1; offset = fPos - 1;
} }
}
return NS_OK; return NS_OK;
} }

4
mailnews/compose/src/nsMsgCompose.h
View file

@ -93,7 +93,7 @@ protected:
nsresult MoveToAboveQuote(void); nsresult MoveToAboveQuote(void);
nsresult MoveToBeginningOfDocument(void); nsresult MoveToBeginningOfDocument(void);
nsresult MoveToEndOfDocument(void); nsresult MoveToEndOfDocument(void);
nsresult ReplaceFileURLs(nsAutoString &sigData); nsresult ReplaceFileURLs(nsString &sigData);
nsresult DataURLForFileURL(const nsAString &aFileURL, nsAString &aDataURL); nsresult DataURLForFileURL(const nsAString &aFileURL, nsAString &aDataURL);
// 3 = To, Cc, Bcc // 3 = To, Cc, Bcc
@ -147,7 +147,7 @@ protected:
}; };
//////////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////////
// THIS IS THE CLASS THAT IS THE STREAM Listener OF THE HTML OUPUT // THIS IS THE CLASS THAT IS THE STREAM Listener OF THE HTML OUTPUT
// FROM LIBMIME. THIS IS FOR QUOTING // FROM LIBMIME. THIS IS FOR QUOTING
//////////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////////
class QuotingOutputStreamListener : public nsIMsgQuotingOutputStreamListener class QuotingOutputStreamListener : public nsIMsgQuotingOutputStreamListener