wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-10-31 11:37:30 +09:00
Code Issues Projects Releases Packages Wiki Activity

Issue #2532 - Don't do PreventDefault for escape key if <select> dropdown is not shown

Browse source 
We always use PreventDefault for <select> element, which is problematic if modal
dialog is on as it prevents cancelling the dialog. We fix it by not blocking the
default action if <select> is not shown.

See Bug 1649278
This commit is contained in:
Moonchild 2024-06-15 12:33:06 +02:00 • committed by roytam1
commit 368ee51d86
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
layout/forms/nsListControlFrame.cpp
View file

@ -2236,11 +2236,20 @@ nsListControlFrame::KeyDown(nsIDOMEvent* aKeyEvent)
return NS_OK; return NS_OK;
} }
// We don't want to preventDefault for escape key if the dropdown
// popup is not shown.
// Need to do the check before AboutToRollup because AboutToRollup
// may update the dropdown flags.
bool doPreventDefault =
!mComboboxFrame || mComboboxFrame->IsDroppedDownOrHasParentPopup();
AboutToRollup(); AboutToRollup();
// If the select element is a dropdown style, Enter key should be // If the select element is a dropdown style, Escape key should be
// consumed everytime since Escape key may be pressed accidentally after // consumed everytime since Escape key may be pressed accidentally after
// the dropdown is closed by Escepe key. // the dropdown is closed by Escepe key.
if (doPreventDefault) {
aKeyEvent->PreventDefault(); aKeyEvent->PreventDefault();
}
return NS_OK; return NS_OK;
} }
case NS_VK_PAGE_UP: { case NS_VK_PAGE_UP: {