wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-29 11:57:32 +09:00
Code Issues Projects Releases Packages Wiki Activity

Prevent the existance of dangling pointers upon failure of FindDataStart.

Browse source
This commit is contained in:
Bas Schouten 2020-05-05 23:22:19 +00:00 • committed by Roy Tam
commit 27ea0aaf55
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
modules/libjar/nsZipArchive.cpp
View file

@ -217,16 +217,17 @@ nsresult nsZipHandle::Init(nsIFile *file, nsZipHandle **ret,
#else #else
handle->mNSPRFileDesc = fd.forget(); handle->mNSPRFileDesc = fd.forget();
#endif #endif
handle->mMap = map;
handle->mFile.Init(file); handle->mFile.Init(file);
handle->mTotalLen = (uint32_t) size; handle->mTotalLen = (uint32_t) size;
handle->mFileStart = buf; handle->mFileStart = buf;
rv = handle->findDataStart(); rv = handle->findDataStart();
if (NS_FAILED(rv)) { if (NS_FAILED(rv)) {
PR_MemUnmap(buf, (uint32_t) size); PR_MemUnmap(buf, (uint32_t) size);
handle->mFileStart = nullptr;
PR_CloseFileMap(map); PR_CloseFileMap(map);
return rv; return rv;
} }
handle->mMap = map;
handle.forget(ret); handle.forget(ret);
return NS_OK; return NS_OK;
} }