wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-10-28 18:17:29 +09:00
Code Issues Projects Releases Packages Wiki Activity

Add a nullcheck on pipelined HTTP connections' pushback.

Browse source
This commit is contained in:
wolfbeast 2018-11-20 09:17:31 +01:00 • committed by Roy Tam
commit 2057017d69
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
netwerk/protocol/http/nsHttpPipeline.cpp
View file

@ -291,6 +291,11 @@ nsHttpPipeline::PushBack(const char *data, uint32_t length)
MOZ_ASSERT(PR_GetCurrentThread() == gSocketThread); MOZ_ASSERT(PR_GetCurrentThread() == gSocketThread);
MOZ_ASSERT(mPushBackLen == 0, "push back buffer already has data!"); MOZ_ASSERT(mPushBackLen == 0, "push back buffer already has data!");
// Some bad behaving proxies may yank the connection out from under us.
// Check if we still have a connection to work with.
if (!mConnection)
return NS_ERROR_FAILURE;
// If we have no chance for a pipeline (e.g. due to an Upgrade) // If we have no chance for a pipeline (e.g. due to an Upgrade)
// then push this data down to original connection // then push this data down to original connection
if (!mConnection->IsPersistent()) if (!mConnection->IsPersistent())