wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-10-22 15:17:29 +09:00
Code Issues Projects Releases Packages Wiki Activity

Specify an explicit offset when warning about "use asm" found in the

Browse source 
directive prologue of a script (rather than a function body).
This commit is contained in:
wolfbeast 2019-04-05 21:30:52 +02:00 • committed by Roy Tam
commit 1f00dc49d4
3 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
js/src/frontend/FullParseHandler.h
View file

@ -845,7 +845,7 @@ class FullParseHandler
MOZ_MUST_USE ParseNode* setLikelyIIFE(ParseNode* pn) { MOZ_MUST_USE ParseNode* setLikelyIIFE(ParseNode* pn) {
return parenthesize(pn); return parenthesize(pn);
} }
void setPrologue(ParseNode* pn) { void setInDirectivePrologue(ParseNode* pn) {
pn->pn_prologue = true; pn->pn_prologue = true;
} }

9
js/src/frontend/Parser.cpp
View file

@ -3811,10 +3811,10 @@ Parser<FullParseHandler>::asmJS(Node list)
*/ */
template <typename ParseHandler> template <typename ParseHandler>
bool bool
Parser<ParseHandler>::maybeParseDirective(Node list, Node pn, bool* cont) Parser<ParseHandler>::maybeParseDirective(Node list, Node possibleDirective, bool* cont)
{ {
TokenPos directivePos; TokenPos directivePos;
JSAtom* directive = handler.isStringExprStatement(pn, &directivePos); JSAtom* directive = handler.isStringExprStatement(possibleDirective, &directivePos);
*cont = !!directive; *cont = !!directive;
if (!*cont) if (!*cont)
@ -3831,7 +3831,7 @@ Parser<ParseHandler>::maybeParseDirective(Node list, Node pn, bool* cont)
// directive in the future. We don't want to interfere with people // directive in the future. We don't want to interfere with people
// taking advantage of directive-prologue-enabled features that appear // taking advantage of directive-prologue-enabled features that appear
// in other browsers first. // in other browsers first.
handler.setPrologue(pn); handler.setInDirectivePrologue(possibleDirective);
if (directive == context->names().useStrict) { if (directive == context->names().useStrict) {
// Functions with non-simple parameter lists (destructuring, // Functions with non-simple parameter lists (destructuring,
@ -3867,7 +3867,8 @@ Parser<ParseHandler>::maybeParseDirective(Node list, Node pn, bool* cont)
} else if (directive == context->names().useAsm) { } else if (directive == context->names().useAsm) {
if (pc->isFunctionBox()) if (pc->isFunctionBox())
return asmJS(list); return asmJS(list);
return reportWithNode(ParseWarning, false, pn, JSMSG_USE_ASM_DIRECTIVE_FAIL); return reportWithOffset(ParseWarning, false, directivePos.begin,
JSMSG_USE_ASM_DIRECTIVE_FAIL);
} }
} }
return true; return true;

2
js/src/frontend/SyntaxParseHandler.h
View file

@ -519,7 +519,7 @@ class SyntaxParseHandler
MOZ_MUST_USE Node setLikelyIIFE(Node pn) { MOZ_MUST_USE Node setLikelyIIFE(Node pn) {
return pn; // Remain in syntax-parse mode. return pn; // Remain in syntax-parse mode.
} }
void setPrologue(Node pn) {} void setInDirectivePrologue(Node pn) {}
bool isConstant(Node pn) { return false; } bool isConstant(Node pn) { return false; }