From 6b13231b9662601a975b283c2ead16e61bd69fb9 Mon Sep 17 00:00:00 2001 From: Job Bautista Date: Mon, 1 May 2023 20:27:31 +0800 Subject: [PATCH 1/5] [Basilisk] Issue MoonchildProductions/UXP#1451 - Follow-up: Only copy hunspell shared library if we're not building against system Hunspell. We've never supported system Hunspell AFAICS, but if that time comes, we should prevent packaging from breaking if building against system Hunspell on *nix. --- application/basilisk/installer/package-manifest.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/application/basilisk/installer/package-manifest.in b/application/basilisk/installer/package-manifest.in index 37dfcdae3b..fe5103bd5d 100644 --- a/application/basilisk/installer/package-manifest.in +++ b/application/basilisk/installer/package-manifest.in @@ -73,8 +73,9 @@ #ifdef GKMEDIAS_SHARED_LIBRARY @BINPATH@/@DLL_PREFIX@gkmedias@DLL_SUFFIX@ #endif -; Hunspell +#ifndef MOZ_SYSTEM_HUNSPELL @BINPATH@/@DLL_PREFIX@hunspell@DLL_SUFFIX@ +#endif #ifndef MOZ_SYSTEM_NSPR #ifndef MOZ_FOLD_LIBS @BINPATH@/@DLL_PREFIX@nspr4@DLL_SUFFIX@ From aadd6244c1d38f4544e150ff724ccbcdc7b43b29 Mon Sep 17 00:00:00 2001 From: Job Bautista Date: Mon, 1 May 2023 20:27:31 +0800 Subject: [PATCH 2/5] [Pale-Moon] Issue MoonchildProductions/UXP#1451 - Follow-up: Only copy hunspell shared library if we're not building against system Hunspell. We've never supported system Hunspell AFAICS, but if that time comes, we should prevent packaging from breaking if building against system Hunspell on *nix. --- application/palemoon/installer/package-manifest.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/application/palemoon/installer/package-manifest.in b/application/palemoon/installer/package-manifest.in index c2c1201b74..1961f9e937 100644 --- a/application/palemoon/installer/package-manifest.in +++ b/application/palemoon/installer/package-manifest.in @@ -66,8 +66,9 @@ #ifdef GKMEDIAS_SHARED_LIBRARY @BINPATH@/@DLL_PREFIX@gkmedias@DLL_SUFFIX@ #endif -; Hunspell +#ifndef MOZ_SYSTEM_HUNSPELL @BINPATH@/@DLL_PREFIX@hunspell@DLL_SUFFIX@ +#endif #ifndef MOZ_SYSTEM_NSPR #ifndef MOZ_FOLD_LIBS @BINPATH@/@DLL_PREFIX@nspr4@DLL_SUFFIX@ From 4a9e6100ec5570d384ae3e891a2d04c846423d3c Mon Sep 17 00:00:00 2001 From: FranklinDM Date: Sun, 4 Dec 2022 12:14:18 +0800 Subject: [PATCH 3/5] [Pale-Moon] No issue - Silence tab closing animation assert if the tabbrowser is not visible --- application/palemoon/base/content/tabbrowser.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/application/palemoon/base/content/tabbrowser.xml b/application/palemoon/base/content/tabbrowser.xml index 6bc5a33ce9..52e39d898b 100644 --- a/application/palemoon/base/content/tabbrowser.xml +++ b/application/palemoon/base/content/tabbrowser.xml @@ -1972,7 +1972,9 @@ setTimeout(function (tab, tabbrowser) { if (tab.parentNode && window.getComputedStyle(tab).maxWidth == "0.1px") { - NS_ASSERT(false, "Giving up waiting for the tab closing animation to finish (bug 608589)"); + if (this.visible) { + NS_ASSERT(false, "Giving up waiting for the tab closing animation to finish (bug 608589)"); + } tabbrowser._endRemoveTab(tab); } }, 3000, aTab, this); From a39686b91bb81cd3eb700d25c60f255028f50f42 Mon Sep 17 00:00:00 2001 From: FranklinDM Date: Sun, 4 Dec 2022 12:15:24 +0800 Subject: [PATCH 4/5] [Pale-Moon] No issue - Ensure window.location exists before checking against the browser URL --- application/palemoon/base/content/browser-places.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/application/palemoon/base/content/browser-places.js b/application/palemoon/base/content/browser-places.js index 7130f7f28a..4283ad25c2 100644 --- a/application/palemoon/base/content/browser-places.js +++ b/application/palemoon/base/content/browser-places.js @@ -428,7 +428,7 @@ var PlacesCommandHook = { */ updateBookmarkAllTabsCommand: function() { // There's nothing to do in non-browser windows. - if (window.location.href != getBrowserURL()) { + if (!window.location || window.location.href != getBrowserURL()) { return; } From 1ae0d6ff7f594f24670039a7e4a31205a01000e8 Mon Sep 17 00:00:00 2001 From: FranklinDM Date: Tue, 31 Jan 2023 02:32:35 +0800 Subject: [PATCH 5/5] [Pale-Moon] No issue - Remove invalid key attribute on Permissions menu item There wasn't any assigned key combination for the Permissions page when this menu item was added. This is a follow-up to c2fd8a6466e1005f4266753708e7c8a38442db54 Oddly enough, there's actually a check if the key element exists. Unlike the warning for key conflicts on keyboards, this one doesn't show up on the Error Console and is available only on debug builds. --- application/palemoon/base/content/browser-appmenu.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/application/palemoon/base/content/browser-appmenu.inc b/application/palemoon/base/content/browser-appmenu.inc index 17d1030498..07115b7bff 100644 --- a/application/palemoon/base/content/browser-appmenu.inc +++ b/application/palemoon/base/content/browser-appmenu.inc @@ -306,8 +306,7 @@ + command="Tools:Permissions"/> #ifdef MOZ_SERVICES_SYNC