wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-29 20:07:30 +09:00
Code Issues Projects Releases Packages Wiki Activity

Issue #1742 - Part 5: Remove unnecessary GCPtr::unbarrieredGet

Browse source 
Ref: BZ 1323441
This commit is contained in:
Jeremy Andrews 2022-05-27 07:25:48 -05:00 • committed by roytam1
commit 1cdbf6eb6a
4 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
js/src/gc/Barrier.h
View file

@ -454,10 +454,6 @@ class GCPtr : public WriteBarrieredBase<T>
DECLARE_POINTER_ASSIGN_OPS(GCPtr, T); DECLARE_POINTER_ASSIGN_OPS(GCPtr, T);
T unbarrieredGet() const {
return this->value;
}
private: private:
void set(const T& v) { void set(const T& v) {
this->pre(); this->pre();

2
js/src/vm/NativeObject-inl.h
View file

@ -290,7 +290,7 @@ NativeObject::setSlotWithType(ExclusiveContext* cx, Shape* shape,
inline void inline void
NativeObject::updateShapeAfterMovingGC() NativeObject::updateShapeAfterMovingGC()
{ {
Shape* shape = shape_.unbarrieredGet(); Shape* shape = shape_;
if (IsForwarded(shape)) if (IsForwarded(shape))
shape_.unsafeSet(Forwarded(shape)); shape_.unsafeSet(Forwarded(shape));
} }

2
js/src/vm/ObjectGroup.cpp
View file

@ -421,7 +421,7 @@ struct ObjectGroupCompartment::NewEntry
} }
static inline bool match(const ObjectGroupCompartment::NewEntry& key, const Lookup& lookup) { static inline bool match(const ObjectGroupCompartment::NewEntry& key, const Lookup& lookup) {
TaggedProto proto = key.group.unbarrieredGet()->proto().unbarrieredGet(); TaggedProto proto = key.group.unbarrieredGet()->proto();
JSObject* assoc = key.associated; JSObject* assoc = key.associated;
MOZ_ASSERT(proto.hasUniqueId()); MOZ_ASSERT(proto.hasUniqueId());
MOZ_ASSERT_IF(assoc, assoc->zone()->hasUniqueId(assoc)); MOZ_ASSERT_IF(assoc, assoc->zone()->hasUniqueId(assoc));

2
js/src/vm/Shape-inl.h
View file

@ -123,7 +123,7 @@ Shape::new_(ExclusiveContext* cx, Handle<StackShape> other, uint32_t nfixed)
inline void inline void
Shape::updateBaseShapeAfterMovingGC() Shape::updateBaseShapeAfterMovingGC()
{ {
BaseShape* base = base_.unbarrieredGet(); BaseShape* base = base_;
if (IsForwarded(base)) if (IsForwarded(base))
base_.unsafeSet(Forwarded(base)); base_.unsafeSet(Forwarded(base));
} }