From 12231d9266edad85a5bcba405e60aa2988b73649 Mon Sep 17 00:00:00 2001 From: Moonchild Date: Fri, 30 Jul 2021 09:58:15 +0000 Subject: [PATCH] Issue #1679 - Part4: Clean up commented-out/WIP code. --- js/src/regexp/regexp-native-macro-assembler.cc | 11 ----------- js/src/regexp/regexp-shim.cc | 2 -- js/src/regexp/regexp-shim.h | 1 - 3 files changed, 14 deletions(-) diff --git a/js/src/regexp/regexp-native-macro-assembler.cc b/js/src/regexp/regexp-native-macro-assembler.cc index bfac5be072..67bf77cbd8 100644 --- a/js/src/regexp/regexp-native-macro-assembler.cc +++ b/js/src/regexp/regexp-native-macro-assembler.cc @@ -89,17 +89,6 @@ void SMRegExpMacroAssembler::AdvanceRegister(int reg, int by) { } void SMRegExpMacroAssembler::Backtrack() { - // Check for an interrupt. - /*Label noInterrupt; - Address lhs = Address(cx_->runtime()->addressOfInterruptUint32()); - masm_.branchtest32(Assembler::Zero, - lhs, - Imm32(0), - &noInterrupt); - masm_.movePtr(ImmWord(RegExpRunStatus_Error), temp0_); - masm_.jump(&exit_label_); - masm_.bind(&noInterrupt); -*/ // Pop code location from backtrack stack and jump to location. Pop(temp0_); masm_.jump(temp0_); diff --git a/js/src/regexp/regexp-shim.cc b/js/src/regexp/regexp-shim.cc index 024ccc2568..275fafdf0b 100644 --- a/js/src/regexp/regexp-shim.cc +++ b/js/src/regexp/regexp-shim.cc @@ -127,8 +127,6 @@ PseudoHandle ByteArray::takeOwnership(Isolate* isolate) { } void Isolate::trace(JSTracer* trc) { - //js::gc::AssertRootMarkingPhase(trc); - for (auto iter = handleArena_.Iter(); !iter.Done(); iter.Next()) { auto& elem = iter.Get(); JS::GCPolicy::trace(trc, &elem, "Isolate handle arena"); diff --git a/js/src/regexp/regexp-shim.h b/js/src/regexp/regexp-shim.h index dc24b6c3d3..aa8c98be86 100644 --- a/js/src/regexp/regexp-shim.h +++ b/js/src/regexp/regexp-shim.h @@ -1173,7 +1173,6 @@ extern bool FLAG_trace_regexp_bytecodes; extern bool FLAG_trace_regexp_parser; extern bool FLAG_trace_regexp_peephole_optimization; -// #define V8_USE_COMPUTED_GOTO 1 #define COMPILING_IRREGEXP_FOR_EXTERNAL_EMBEDDER } // namespace internal