From 0fc38724d1d5f150d7a62b7d4652162a75e55f4c Mon Sep 17 00:00:00 2001 From: Brian Smith Date: Mon, 17 Jul 2023 02:01:35 -0500 Subject: [PATCH] No Issue - Fix intermitted crash on MacOS 14 Sonoma Beta 3. Not sure why this is happening but mIOSurface is nullptr. If we just skip binding, it will be created on the next call to BeginUpdate. --- widget/cocoa/RectTextureImage.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/widget/cocoa/RectTextureImage.mm b/widget/cocoa/RectTextureImage.mm index c67af97d0a..270ac5d8b5 100644 --- a/widget/cocoa/RectTextureImage.mm +++ b/widget/cocoa/RectTextureImage.mm @@ -144,7 +144,7 @@ RectTextureImage::DeleteTexture() void RectTextureImage::BindIOSurfaceToTexture(gl::GLContext* aGL) { - if (!mTexture) { + if (!mTexture && mIOSurface) { MOZ_ASSERT(aGL); aGL->fGenTextures(1, &mTexture); aGL->fActiveTexture(LOCAL_GL_TEXTURE0);