Issue #2078 - Part 2: Rename nsPseudoClassList->u.mSelectors to mSelectorList

This makes it clear that we're accessing a selector list (nsCSSSelectorList), which is different from the selectors (nsCSSSelector) contained inside a selector list. Previously, both were confusingly referred to as mSelectors.
This commit is contained in:
FranklinDM 2023-02-18 11:05:36 +08:00 committed by roytam1
commit 0648ec64bb
3 changed files with 9 additions and 9 deletions

View file

@ -153,7 +153,7 @@ nsPseudoClassList::nsPseudoClassList(CSSPseudoClassType aType,
"unexpected pseudo-class");
NS_ASSERTION(aSelectorList, "selector list expected");
MOZ_COUNT_CTOR(nsPseudoClassList);
u.mSelectors = aSelectorList;
u.mSelectorList = aSelectorList;
}
nsPseudoClassList*
@ -170,7 +170,7 @@ nsPseudoClassList::Clone(bool aDeep) const
NS_ASSERTION(nsCSSPseudoClasses::HasSelectorListArg(mType),
"unexpected pseudo-class");
// This constructor adopts its selector list argument.
result = new nsPseudoClassList(mType, u.mSelectors->Clone());
result = new nsPseudoClassList(mType, u.mSelectorList->Clone());
}
if (aDeep)
@ -199,7 +199,7 @@ nsPseudoClassList::SizeOfIncludingThis(mozilla::MallocSizeOf aMallocSizeOf) cons
} else {
NS_ASSERTION(nsCSSPseudoClasses::HasSelectorListArg(p->mType),
"unexpected pseudo-class");
n += p->u.mSelectors->SizeOfIncludingThis(aMallocSizeOf);
n += p->u.mSelectorList->SizeOfIncludingThis(aMallocSizeOf);
}
p = p->mNext;
}
@ -210,7 +210,7 @@ nsPseudoClassList::~nsPseudoClassList(void)
{
MOZ_COUNT_DTOR(nsPseudoClassList);
if (nsCSSPseudoClasses::HasSelectorListArg(mType)) {
delete u.mSelectors;
delete u.mSelectorList;
} else if (u.mMemory) {
free(u.mMemory);
}
@ -927,7 +927,7 @@ nsCSSSelector::AppendToStringWithoutCombinatorsOrNegations
NS_ASSERTION(nsCSSPseudoClasses::HasSelectorListArg(list->mType),
"unexpected pseudo-class");
nsString tmp;
list->u.mSelectors->ToString(tmp, aSheet);
list->u.mSelectorList->ToString(tmp, aSheet);
aString.Append(tmp);
}
aString.Append(char16_t(')'));