wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-05 07:18:39 +09:00
Code Issues Projects Releases Packages Wiki Activity

Fix toolkit update logic to prevent update loops.

Browse source 
Only consider equal appversion to be "update available" if BuildID is present AND greater than current.

This resolves #13.
This commit is contained in:
wolfbeast 2017-06-19 18:39:27 +02:00 • committed by Roy Tam
commit 05eb40a155
1 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
toolkit/mozapps/update/nsUpdateService.js
View file

@ -2395,14 +2395,16 @@ UpdateService.prototype = {
let lastCheckCode = AUSTLMY.CHK_NO_COMPAT_UPDATE_FOUND;
updates.forEach(function(aUpdate) {
// Ignore updates for older versions of the application and updates for
// the same version of the application with the same build ID.
// Ignore updates for older versions of the applications and updates for
// the same version or build id of the application
if (vc.compare(aUpdate.appVersion, Services.appinfo.version) < 0 ||
vc.compare(aUpdate.appVersion, Services.appinfo.version) == 0 &&
aUpdate.buildID == Services.appinfo.appBuildID) {
(vc.compare(aUpdate.appVersion, Services.appinfo.version) == 0 &&
aUpdate.buildID <= Services.appinfo.appBuildID) ||
(vc.compare(aUpdate.appVersion, Services.appinfo.version) == 0 &&
aUpdate.buildID == undefined)) {
LOG("UpdateService:selectUpdate - skipping update because the " +
"update's application version is less than the current " +
"application version");
"update's application version is less than or equal to " +
"the current application version.");
lastCheckCode = AUSTLMY.CHK_UPDATE_PREVIOUS_VERSION;
return;
}