From 00a5d640183eea8b8fb5da81cbea76ab57d0e6f9 Mon Sep 17 00:00:00 2001 From: Job Bautista Date: Mon, 20 Jun 2022 21:44:59 +0800 Subject: [PATCH] Issue #1769 - Part 1 Follow-up: Tidy up moz.build for highway and libjxl highway upstream added a new header file to be included in highway.h after 0.15.0 it seems, so we have to account for that in moz.build. Also brought back allowing compiler warnings for libjxl and highway. Apparently the equivalent of AllowCompilerWarnings() is a bool whose name is UPPERCASE and uses under_scores instead of CamelCase. --- media/highway/moz.build | 4 ++++ media/libjxl/moz.build | 3 +++ 2 files changed, 7 insertions(+) diff --git a/media/highway/moz.build b/media/highway/moz.build index f7ef48ba28..da8876c5b7 100644 --- a/media/highway/moz.build +++ b/media/highway/moz.build @@ -30,6 +30,7 @@ EXPORTS.hwy += [ EXPORTS.hwy.ops += [ "/media/highway/src/hwy/ops/arm_neon-inl.h", "/media/highway/src/hwy/ops/arm_sve-inl.h", + "/media/highway/src/hwy/ops/emu128-inl.h", "/media/highway/src/hwy/ops/generic_ops-inl.h", "/media/highway/src/hwy/ops/rvv-inl.h", "/media/highway/src/hwy/ops/scalar-inl.h", @@ -42,3 +43,6 @@ EXPORTS.hwy.ops += [ ] FINAL_LIBRARY = "gkmedias" + +# We allow warnings for third-party code that can be updated from upstream. +ALLOW_COMPILER_WARNINGS = True diff --git a/media/libjxl/moz.build b/media/libjxl/moz.build index 09dea2583e..d3e8c4a988 100644 --- a/media/libjxl/moz.build +++ b/media/libjxl/moz.build @@ -131,6 +131,9 @@ EXPORTS.jxl += [ FINAL_LIBRARY = "gkmedias" +# We allow warnings for third-party code that can be updated from upstream. +ALLOW_COMPILER_WARNINGS = True + # Clang 5.0 has a compiler bug that prevents build in c++17 # See https://gitlab.com/wg1/jpeg-xl/-/issues/227 # This should be okay since we are using the C API.