wayland: clean up destroyedWidgetsTableMutex remenants
All checks were successful
pyrite-dev/milsko/pipeline/head This commit looks good
All checks were successful
pyrite-dev/milsko/pipeline/head This commit looks good
This commit is contained in:
parent
14915e082a
commit
8fe9a1c168
1 changed files with 0 additions and 12 deletions
|
|
@ -10,14 +10,6 @@ wayland_call_table_t wl_call_tbl;
|
|||
MwBool MwWaylandVulkan = MwFALSE;
|
||||
#endif
|
||||
|
||||
static pthread_mutex_t destroyedWidgetsTableMutex;
|
||||
/*
|
||||
* So Wayland, bless its soul; it keeps using callbacks LONG after they should not only be destroyed but the widget doesn't even exist anymore. Naturally, this causes use after free. so we fight fire with fire in the worst code i've ever written: by storing the freed pointers here, we disallow wayland from ever using them again. if something else is created that takes this slot, we remove it from the table.
|
||||
*
|
||||
* TODO(IOI): FUCKING NO???? FIX THIS.
|
||||
*/
|
||||
static MwLL* destroyedWidgetsTable;
|
||||
|
||||
static int event_loop(MwLL handle);
|
||||
|
||||
/* Recursively dispatch a resize event to a widget and its children */
|
||||
|
|
@ -749,10 +741,6 @@ static void MwLLDestroyImpl(MwLL handle) {
|
|||
|
||||
MwLLWaylandFlush(handle);
|
||||
|
||||
pthread_mutex_lock(&destroyedWidgetsTableMutex);
|
||||
arrput(destroyedWidgetsTable, handle);
|
||||
pthread_mutex_unlock(&destroyedWidgetsTableMutex);
|
||||
|
||||
free(handle);
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue